Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: increase default timeout transfer leader in upgrade progress #1434

Merged
merged 3 commits into from
Jun 21, 2021
Merged

cluster: increase default timeout transfer leader in upgrade progress #1434

merged 3 commits into from
Jun 21, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Jun 18, 2021 •
edited
Loading

What problem does this PR solve?

Close #1432

What is changed and how it works?

Increase default timeout of transfer leader from 300s to 600s during upgrade process. Note that user can always set another value as they wish with --transfer-timeout argument.

Also implement -s/--signal argument support for systemd module, but not used for TiKV for now, as the necessary meta needed to validate TiKV versions are not available where it is called, and the change would be too large to be added into a patch release.

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.5.2 milestone Jun 18, 2021
@AstroProfundis AstroProfundis self-assigned this Jun 18, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021 •
edited
Loading

Codecov Report

Merging #1434 (5267a37) into master (7b0c5e1) will increase coverage by 8.35%.
The diff coverage is 33.33%.

❗ Current head 5267a37 differs from pull request most recent head 52f03e6. Consider uploading reports for the commit 52f03e6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   25.23%   33.59%   +8.35%     
==========================================
  Files         264      225      -39     
  Lines       20743    17978    -2765     
==========================================
+ Hits         5235     6039     +804     
+ Misses      14705    10870    -3835     
- Partials      803     1069     +266
Flag Coverage Δ
cluster 33.59% <33.33%> (?)
integrate 33.59% <33.33%> (+18.16%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/module/systemd.go 64.00% <0.00%> (+64.00%) ⬆️
pkg/cluster/operation/upgrade.go 22.72% <ø> (ø)
components/cluster/command/upgrade.go 42.10% <100.00%> (ø)
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-82.50%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/utils/semver.go 5.21% <0.00%> (-80.00%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-80.00%) ⬇️
... and 236 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0c5e1...52f03e6. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 52f03e6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-chi-bot ti-chi-bot merged commit 7176e38 into pingcap:master Jun 21, 2021
@AstroProfundis AstroProfundis deleted the issue-1432 branch June 21, 2021 04:39
AstroProfundis added a commit that referenced this pull request Jun 24, 2021
@AstroProfundis
cluster: increase default timeout transfer leader in upgrade progress (…
b21b24b 
…#1434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove approved these changes

Assignees

@AstroProfundis AstroProfundis

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.

Terminate tikv server instead of killing it when evict leader timeout or is skipped
4 participants
@AstroProfundis @codecov-commenter @ti-chi-bot @lucklove